Closed mikkelbu closed 3 years ago
Apologies. It had been committed locally and looks to have failed the push. Should be up to date now.
No problem. We just try to check what the changes are when we are bumping our dependencies. Thanks for the quick answer 👍.
We got notified by dependabot that a new version of NPoco was pushed. When we examined the changes we were a bit unsure whether there were any changes as 5.3.1 is not mentioned in this repository.
I've compared the nuget files using fuget.org and not found any differences at the API level, but if I compare the IL I can see that the code for the lambda expression for
ComplexPropertiesWhere
in FluentMappingConfiguration,cs is different (this is the only non-trivial difference as far as I can tell).https://github.com/schotime/NPoco/blob/ea9db72d0d89ee532ffe3a2d2cc1bf245ecf814d/src/NPoco/FluentMappings/FluentMappingConfiguration.cs#L176-L177
In 5.3.0 the IL generated for
ComplexPropertiesWhere
is similar to the one generated forReferencePropertiesWhere
which makes sense looking at the code onmaster
, but in 5.3.1 is it different.IL in 5.3.0
IL in 5.3.1
So it seems that before we just asked whether the attribute existed. Now we also access the property
ComplexMapping
(onComplexMappingAttribute
). Was this just a change forgotten in https://github.com/schotime/NPoco/commit/2e96dbc533fa5d91af62082113933b51f08ba914#diff-d1f54cbfb911590df55eb5a792983526a9eb5a4aff0a786698e648841153d27e that have not been pushed yet ?EDIT: It looks like the two versions were created on the same day - August 25.