search

schourode / iso3166

ISO 3166-1 country list for .NET
MIT License
76 stars 31 forks source link

Added primary subdivisions #1

Closed lynx44 closed 7 years ago

lynx44 commented 11 years ago

Added ISO3166-2 primary subdivisions to relevant countries

schourode commented 11 years ago

First and foremost, I am terribly sorry for the long delay in getting back to you.

I think subdivisions is a good idea, and having them "nested" within the relevant Country instances seems like a good choice. However, it seems like you have included subdivisions only for some of the countries mentioned in the Wikipedia article on ISO 3166-2. Why is that?

lynx44 commented 11 years ago

Good question. When I originally added this code, I used an internal database at my work place to find all countries that had subdivisions, then used Google to source each country's subdivisions from Wikipedia. I didn't see this link that you've referenced, so I didn't realize I was missing other countries that have primary subdivisions. Clearly, our internal database was inaccurate.

I don't have time to update the other countries now, but I'll see if I can fit it in soon!