search

schourode / iso3166

ISO 3166-1 country list for .NET
MIT License
76 stars 31 forks source link

Check date #13

Closed ghost closed 4 years ago

ghost commented 4 years ago

Added date when I checked the code against the official ISO 3166-1 It adds the value as saying: this is from Wikipedia, does not sound really assuring and there is really nothing special in checking this against the official content. I think the package should not mention Wikipedia at all.

andersnm commented 4 years ago

Thanks! You're most welcome to amend the PR and remove any mentions of Wikipedia if you wish

ghost commented 4 years ago

Done.

And Å sorted to be last after Z as per the official source. Å is previous double aa in Norwegian and it comes after Z

Aleksandar

On Wed, Jan 8, 2020 at 12:00 PM andersnm notifications@github.com wrote:

Thanks! You're most welcome to amend the PR and remove any mentions of Wikipedia if you wish

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/schourode/iso3166/pull/13?email_source=notifications&email_token=ADG5B3TFHU3VKOL3TOYTZPTQ4WW3TA5CNFSM4KEGPOA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIMAF6I#issuecomment-571998969, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADG5B3XY7IW3UHSTYH7PZDTQ4WW3TANCNFSM4KEGPOAQ .