search

schovi / react-iscroll

React component for wrapping iScroll http://iscrolljs.com/
MIT License
236 stars 60 forks source link

react-dom not in package JSON #15

Closed vinceprofeta closed 8 years ago

vinceprofeta commented 8 years ago

Is there a reason react-dom is not included in the package JSON? When I try to build my project react-dom is missing.

schovi commented 8 years ago

react is just peerDepencency, because you can have custom build or any version. And react-dom from my point of view is not necessary. You can have custom renderer (react-native react-svg or whatever). You can use this library without it and your application should decide what to do with that.

josephfinlayson commented 8 years ago

It is necessary

Module not found: Error: Cannot resolve module 'react-dom' in /home/joe/www/frontend/node_modules/react-iscroll/dist

josephfinlayson commented 8 years ago

Offending line in dist:

var iScrollInstance = new iScroll(_reactDom2['default'].findDOMNode(this), options);

schovi commented 8 years ago

@josephfinlayson My bad! Facepalm

schovi commented 8 years ago

https://github.com/schovi/react-iscroll/commit/c1e655161321c147a75703b80b4af6b31d131e4a