React v15.5 prop types fix

schovi / react-iscroll

React component for wrapping iScroll http://iscrolljs.com/

MIT License

236 stars 60 forks source link

React v15.5 prop types fix #53

Closed toriaezunama closed 7 years ago

toriaezunama commented 7 years ago

React.PropTypes is deprecate in V15.5 so updated to use prop-types library. Also, updated react related libraries to use the latest

schovi commented 7 years ago

@toriaezunama I guess this is breaking change and should be published with new major version. Like when using React older than 15.5 use 1.x otherwise 2.x ?

toriaezunama commented 7 years ago

Yes, I agree. Bumping the major version indicates breaking changes and this would break for everyone who isn't on the latest version of React.

oallouch commented 7 years ago

Hi everyone, Any release planned ?

schovi commented 7 years ago

@oallouch: I am on it!

schovi commented 7 years ago

@oallouch @toriaezunama

It is up as 2.0.0 Check it please.

oallouch commented 7 years ago

All good for me.

toriaezunama commented 7 years ago

Thanks.