search

schovi / react-iscroll

React component for wrapping iScroll http://iscrolljs.com/
MIT License
236 stars 60 forks source link

1.1.3 causing 'npm ERR! cb() never called!' #54

Closed sinn1 closed 7 years ago

sinn1 commented 7 years ago

We have "react-iscroll": "^1.1.0" in our package.json (allow minor version upgrades) and the new version (1.1.3) results in this error during npm install.

Using "react-iscroll": "1.1.2" instead.

zaggaz commented 7 years ago

+1

gbk commented 7 years ago

+1

alex-mm commented 7 years ago

+1

moxiaohe commented 7 years ago

+1

fengsx commented 7 years ago

+1

yize commented 7 years ago

+1

yukap6 commented 7 years ago

+1

yanbingbing commented 7 years ago

+1

wushanchao commented 7 years ago

+1

eJayYoung commented 7 years ago

+1

pplgin commented 7 years ago

+1

schovi commented 7 years ago

Thx for report. Can you add more info, where this error is thrown? During npm install, or somewhere else? I am trying simulate this on new project and can't reach that state. If you have working example or know how to fix it give me hint.

sinn1 commented 7 years ago

Yea on npm install. Delete node_modules folder and try npm install. Error should be thrown.

schovi commented 7 years ago

Got it. But what the hell :)

schovi commented 7 years ago

Fixed with 1.1.4 https://github.com/schovi/react-iscroll/commit/8828f5e29c43c1fe832e57990cf38bfe49c4a780

Problem was, that I published package with yarn instead of npm