search

schovi / react-iscroll

React component for wrapping iScroll http://iscrolljs.com/
MIT License
236 stars 60 forks source link

added tap / click elements example to readme #55

Open edencorbin opened 7 years ago

edencorbin commented 7 years ago

It took me a little to figure out how to implement the click / tap functionality in react so I thought it would be helpful to add react specific code to the documentation. Let me know if you think so too.

schovi commented 7 years ago

@edencorbin Is it anyhow different when you use it without react-iscroll? If yes, then it makes sense and I will provide some feedback on code itself :)

edencorbin commented 7 years ago

Well, although it is not technically different, it requires setting up a ref, which is a react concept to my knowledge, and then adding a listener event to that ref. I'm a fan of verbose documentation. I noticed there was another closed issue or two about it so I thought I would share the steps. If it doesn't fit in with the documentation, no problem.

schovi commented 7 years ago

@edencorbin My point is, that this is something many times solved and when you google you find same solution or package solving that like https://github.com/zilverline/react-tap-event-plugin So maybe find best solution and just link it in FAQ?