search

schplurtz / a2s

DokuWiki asciitosvg plugin
GNU General Public License v2.0
3 stars 1 forks source link

Update ASCIIToSVG.php #5

Closed aavzz closed 6 years ago

aavzz commented 6 years ago

A more fine-grained control of which box is above and which one is below. {"a2s:layer":"b"} sets the corresponding box to be rendered later (above). {"a2s:layer":"c"} sets the corresponding box to be rendered even more later. a2s-layer

schplurtz commented 6 years ago

Hi, I am really very pleased by your interest in this project. I think I did not expect this plugin to attract people and did not make it clear enough (or at all) that changes in ASCIIToSVG.php should not be proposed here, but instead in upstream asciitosvg. a2s is just a dokuwiki wrapper around ascii2svg project.

Please, propose your patch in dhobsd asciitosvg project. the file to modify there is ASCIIToSVG.php, and applying your modifications should be straight forward. I hope you understand why I close this PR : it really belongs to asciitosvg.

Once the change is integrated in asciitosvg, I will be happy to merge it back into a2s.

Sorry for not having made this clear.

aavzz commented 6 years ago

ok, let's see what they say )