schranz-templating / templating

A template abstraction prototype for php template engines.
MIT License
24 stars 0 forks source link

Spiral: Revalidate the SpiralView Adapter #55

Closed alexander-schranz closed 1 year ago

alexander-schranz commented 1 year ago

Currently the SpiralView Adapter requires a EngineInterface, this we are currently getting directly from the ViewManager here:

https://github.com/schranz-templating/templating/blob/5e8d60d8267f8f89c128e17f5aaecb0294a7853d/src/Integration/Spiral/SpiralView/Bootloader/SpiralViewBootloader.php#L17-L34

This way we are only supporting the NativeEngine, which maybe is not the expected Engine, as StemplerEngine is I think the default one used by Spiral but that sadly did throw an error:

dependency "locale" not found.

Maybe instead it would be better directly call from the ViewManager, we need debug the exists $this->views->renderer call to revalidate this.

alexander-schranz commented 1 year ago

fixed in #60