schreibfaul1 / ESP32-audioI2S

Play mp3 files from SD via I2S
GNU General Public License v3.0
1.1k stars 285 forks source link

Incorrect mix up left/right channel #569

Closed BoloKonstruktor closed 1 year ago

BoloKonstruktor commented 1 year ago

Library modification (mix up left/right channel) introduced incorrect playback of left and right channels. The left channel plays in the right and the right in the left. This can be checked with any stereo test.

BoloKonstruktor commented 1 year ago

The simplest solution to the problem:

// ...
//"przelutowanie" kanałów
int16_t r  = sample[LEFTCHANNEL];
int16_t l = sample[RIGHTCHANNEL];
sample[LEFTCHANNEL] = l;
sample[RIGHTCHANNEL] = r;

computeVUlevel(sample);
// ...

The only question is why the Author changed channels in Commits on July 4, 2023?

schreibfaul1 commented 1 year ago

was removed with the last pull request I had a swap in the audio library and have now swapped it back in the application.

Xk-w commented 1 year ago

Library modification (mix up left/right channel) introduced incorrect playback of left and right channels. The left channel plays in the right and the right in the left. This can be checked with any stereo test.

Yes, I also encountered this issue on July 1, 2023

schreibfaul1 commented 1 year ago

really? l_r.zip

BoloKonstruktor commented 1 year ago

This test test_stereo.zip (publicly available on the internet) plays correctly on all my media devices except for a player using the 'ESP32-audioI2S' library version July 1, 2023.

The problem is already present in the displayed VU-meter, so I exclude incorrect connection of the DAC to the amplifier.