search

schrepfler / puppet-jdk_oracle

Puppet module to install JDK from oracle using wget
Other
1 stars 7 forks source link

Gh7 version is integer #11

Closed 030 closed 8 years ago

030 commented 8 years ago

If jdk_oracle::version is set in hiera then it will be overwritten, but indeed if it is set as a string in hiera then it will be incompatible.

030 commented 8 years ago

If we would merge this then the it is an API change and then it would be 1.0.0. We could add a Release note.

schrepfler commented 8 years ago

Ok, so we can bump the major version and have a notice in the release notes.

schrepfler commented 8 years ago

Merged, let's see how to make the break in compatibility apparent.

030 commented 8 years ago

Yes. I have done the same in this module https://github.com/030/puppet-sftp/blob/master/manifests/init.pp#L13. If sftp::group is defined in hiera then it will be overwritten