schriftgestalt / GlyphsSDK

Scripting SDK for Glyphs
Apache License 2.0
89 stars 37 forks source link

`GSGuide.filter` should not be a `bool` value #55

Closed stone-zeng closed 3 years ago

stone-zeng commented 3 years ago

GSGuide.filter should not be a bool value:

https://github.com/schriftgestalt/GlyphsSDK/blob/0aa2bfddc01b2112987fa81d3dd777fd0a68186b/ObjectWrapper/GlyphsApp/__init__.py#L9993-L10000

In Glyphs, there is the same issue:

guide = Font.masters[0].guides[0]

print(guide)
print(guide.filter)
print(guide.pyobjc_instanceMethods.filter())

Output:

<GSGuide x=257.0 y=355.0 angle=0.0>
True
tags CONTAINS "guide_Test"
schriftgestalt commented 3 years ago

Right. Thanks.