search

schrodinger / coordgenlibs

Schrodinger-developed 2D Coordinate Generation
BSD 3-Clause "New" or "Revised" License
42 stars 28 forks source link

Code ank2829 issue51 #123

Open CodeAnk2829 opened 1 year ago

CodeAnk2829 commented 1 year ago

Resolve the issue #51 as mentioned

ricrogz commented 1 year ago

HI @CodeAnk2829, thanks for your PR. You indeed made the changes suggested in the issue, but as I also mentioned in the issue, since we don't have proper testing in place to make sure these changes don't break the functionality, I'd rather not merge these changes without proper testing.

CodeAnk2829 commented 1 year ago

Thanks @ricrogz for replying. I realized that I have missed something and I will look into the issue again. As of now can you please assign me this issue? because I think I can fix this issue with proper testing.

ricrogz commented 1 year ago

Thanks @ricrogz for replying. I realized that I have missed something and I will look into the issue again. As of now can you please assign me this issue? because I think I can fix this issue with proper testing.

@CodeAnk2829, please don't worry about this. The issue was just filed to document a minor problem that doesn't affect the functionality of the library. Like I said, we won't merge any fixes to this issue because don't have any testing infrastructure in place to make sure that a potential fix doesn't break the functionality in an unexpected way. By now, it is not in our priorities to create such testing infrastructure or fix this issue.

CodeAnk2829 commented 1 year ago

Ok @ricrogz, now I understood.