Some (mostly automated) fixes to readability in coordgenlibs

schrodinger / coordgenlibs

Schrodinger-developed 2D Coordinate Generation

BSD 3-Clause "New" or "Revised" License

42 stars 28 forks source link

Some (mostly automated) fixes to readability in coordgenlibs #42

Closed d-b-w closed 4 years ago

d-b-w commented 4 years ago

Includes:

Applying Schrodinger's canonical clang-format settings
Fixed one bug that clang-tidy pointed out (accessing a moved-from string!)
Running clang-tidy's modernize fixes
Running clang-tidy's add braces to single line statements fixer

I ran the coordgen tests and am building RDKit and Schrodinger to test there, as well.

ricrogz commented 4 years ago

Should we try to enable -Wconversion for maeparser and coordgenlibs CI builds?

d-b-w commented 4 years ago

I'll spin off the include refactor into a separate PR. It's not automated and I hadn't actually meant to put it in this branch. (mmshare seems to build fine, I haven't checked RDKit).