Allow CoordGen to build as DLL on Windows in RDKit

schrodinger / coordgenlibs

Schrodinger-developed 2D Coordinate Generation

BSD 3-Clause "New" or "Revised" License

42 stars 28 forks source link

Allow CoordGen to build as DLL on Windows in RDKit #58

Closed ptosco closed 4 years ago

ptosco commented 4 years ago

I have just noticed that the current RDKit master branch fails to build the CoordGen DLL on Windows. These small changes got the DLL built. Thanks in advance!

d-b-w commented 4 years ago

@ptosco - Would you mind including the error message? I hadn't considered this class part of the public API of coordgen.

ptosco commented 4 years ago

@d-b-w I have just tried to reproduce this from a clean build and I failed. I guess I had some stale CoordGen objects from a previous build, and that when I edited the headers the objects were rebuilt, while the changes themselves were irrelevant. Closing, sorry for bothering.

d-b-w commented 4 years ago

Thanks for following up, Paolo, and I appreciate the report either way.