schrodinger / coordgenlibs

Schrodinger-developed 2D Coordinate Generation
BSD 3-Clause "New" or "Revised" License
42 stars 28 forks source link

add EXPORT_COORDGEN to CoordgenFragmenter class #76

Closed greglandrum closed 4 years ago

greglandrum commented 4 years ago

This is required in order to be able to the static methods from this class in other libraries when using DLL linkage on windows.

It came up during the CI builds of https://github.com/rdkit/rdkit/pull/3319

d-b-w commented 4 years ago

Thanks, Greg! I'm happy to issue an update now if that would help.

greglandrum commented 4 years ago

Thanks for the offer Dan, but I don't think it's super urgent. I added something to the RDKit's cmake configuration to apply the patch, so the builds are working now