search

schrodinger / fixed-data-table-2

A React table component designed to allow presenting millions of rows of data.
http://schrodinger.github.io/fixed-data-table-2/
Other
1.29k stars 291 forks source link

License Omitted in Minification #134

Open 2008marketcrash opened 7 years ago

2008marketcrash commented 7 years ago

I'm using clean-css to minify all the CSS in my code and css from this package is something that I also want to minify with my CSS. The issue is that the convention for comments that need to be preserved is /*! (marking the comment as important) for clean-css. This package's css uses /** for its license comments and thus they get omitted from my minified code.

Expected Behavior

Minifying the css in a different package shouldn't remove the license comments.

Current Behavior

Minifying the css in a different does remove the license comments.

Possible Solution

Change the license comments to be /*!. This way they are marked as important.

Context

My workplace requires that all 3rd party code has a license with it. The work done here is awesome and I'd love to be able to use it.

Your Environment

Inside information so can't give it away... :/

KamranAsif commented 7 years ago

Can you create a PR with this change?