search

schrodinger / pymol-open-source

Open-source foundation of the user-sponsored PyMOL molecular visualization system.
https://pymol.org/
Other
1.15k stars 275 forks source link

Fix testSave_symmetry__mmtf for msgpack-cpp=4.1.2 #262

Closed speleo3 closed 1 year ago

speleo3 commented 1 year ago

Floats may be stored as integers in msgpack, and msgpack-cpp does that proactively since version 4.1.2. That broke the unitCell angle round trip in testSave_symmetry__mmtf.

See also: https://github.com/rcsb/mmtf-c/pull/35 https://github.com/msgpack/msgpack-c/pull/1018

JarrettSJohnson commented 1 year ago

Much appreciated as always.