search

schrodinger / pymol-open-source

Open-source foundation of the user-sponsored PyMOL molecular visualization system.
https://pymol.org/
Other
1.2k stars 281 forks source link

Fix list typehint #396

Closed hp115 closed 2 months ago

JarrettSJohnson commented 2 months ago

Thanks for the PR. Can I ask what the motivation is for the change? list[str] is valid from Python 3.9, which is our minimum Python requirement https://github.com/schrodinger/pymol-open-source/blob/9d3061ca58d8b69d7dad74a68fc13fe81af0ff8e/INSTALL#L12

Also, Python 3.8 is scheduled to be EOL anyway in about a month.

ye11owSub commented 2 months ago

I agree with @JarrettSJohnson. @hp115 For more information, you can check PEP 585