Open Nargaruga opened 2 months ago
there is a considerable offset between the laser pointer and the atom that is actually selected. Reducing cRange in layer1/ScenePicking.cpp does not seem to improve the situation by much.
Applying a vertical offset to the picking projection parameters seems to solve the issue (see commit 43ab48e3fa873b055d51b9b576a83d3148575ac0). The change does not seem to influence other VR interactions (i.e. with the menu or the sequence viewer).
This is a band-aid solution, I assume the correct approach would be to update the following parameters: https://github.com/schrodinger/pymol-open-source/blob/9d3061ca58d8b69d7dad74a68fc13fe81af0ff8e/contrib/vr/OpenVRStub.cpp#L137-L150 But I do not know how they were first extrapolated, nor if they are tied to a specific VR headset (I'm testing the changes on a Meta Quest 3).
This allows the user to select atoms by pointing the laser and pressing the button mapped to
Action1
(typically the trigger), as requested in #378.Some problems are still present:
cRange
inlayer1/ScenePicking.cpp
does not seem to improve the situation by much.Possible improvements:
Additional notes:
openvr_cut_laser
to be set totrue
inlayer1/SettingInfo.h
;#include <thread>
tocontrib/vr/OpenVRControllerModel.cpp
(change not included in the commit). Not sure if it's a configuration issue on my end.