search

schteppe / p2.js

JavaScript 2D physics library
Other
2.64k stars 330 forks source link

GSSolver.solve Deoptimization? #214

Closed jtenner closed 8 years ago

jtenner commented 8 years ago

Deoptimization

Looks like you could get a performance boost in chrome by tweaking this function. I'm not sure exactly what it is. The profiler says it makes a "Call to a Javascript runtime function."

Looks like this one is going to be fun.

schteppe commented 8 years ago

Weird, I didn't get that warning myself. Which Chrome version and which demo? Maybe I have to enable a flag in devtools to get this warning? Thanks.

jtenner commented 8 years ago

Yeah totally. This hasn't happened before, but I happen to be testing my application in chrome canary.

Chrome Version 51.0.2672.0 canary (64-bit)

Just so you know, this is an example that I have personally created. This isn't an example you have provided in the p2.js repo.

The example is here: part-shop example 2 using p2.js

The bundle is pre-created, you just have to download bundle.js and index.html, host it and run it in canary.

I have to explain this carefuly. The deoptimization is inside a webworker. Since bundle.js is both the Worker and the code that runs in the browser, it may be confusing to find.

Edit: Direct link to rawgit.com Edit 2: You do not need to enable a flag to get this warning. I think.

jtenner commented 8 years ago

I wanted to readdress this issue, because I can't reproduce it.

It may have been a chrome bug.

Glad this is over.

Thanks, -Josh