Fix constraint constructor arguments for ts typings.

schteppe / p2.js

JavaScript 2D physics library

Other

2.64k stars 330 forks source link

Fix constraint constructor arguments for ts typings. #227

Closed AgileJoshua closed 8 years ago

AgileJoshua commented 8 years ago

Detected an issue with typescript typings for constraints constructors: http://schteppe.github.io/p2.js/docs/classes/DistanceConstraint.html http://schteppe.github.io/p2.js/docs/classes/GearConstraint.html http://schteppe.github.io/p2.js/docs/classes/LockConstraint.html http://schteppe.github.io/p2.js/docs/classes/PrismaticConstraint.html http://schteppe.github.io/p2.js/docs/classes/RevoluteConstraint.html

schteppe commented 8 years ago

Looks like you removed collideConnected and wakeUpBodies from the options objects? They are passed down to the Constraint base class constructor and used there, so they are needed :) Care to fix? Or should I ? Sorry for not taking care of this earlier.

schteppe commented 8 years ago

Thanks!