search

schubergphilis / chef-acme

Chef cookbook to request SSL certificates at Let's Encrypt
Apache License 2.0
112 stars 74 forks source link

Make private key file location configurable #130

Closed twk3 closed 2 years ago

twk3 commented 2 years ago

location can be configured via chef attributes

This is useful when using chef-acme in recipes that aren't managed by a chef server. (And we don't want to have our private key file match other chef-acme runs from other recipes).

This is the case for the GitLab omnibus package, where we would much rather install this to our own omnibus managed etc folder.

twk3 commented 2 years ago

@stanhu thanks for the review. I don't know how I managed to so consistently miss the i in file :laughing:

stanhu commented 2 years ago

Thanks! Looks good to me.

@thoutenbos Would you mind reviewing? This addresses an issue introduced in https://github.com/schubergphilis/chef-acme/pull/128.

thoutenbos commented 2 years ago

Thanks gents! LGTM