search

schubergphilis / chef-acme

Chef cookbook to request SSL certificates at Let's Encrypt
Apache License 2.0
112 stars 74 forks source link

Chef 13 support #70

Closed rnt closed 7 years ago

rnt commented 7 years ago

Enable acme cookbook to use in Chef 13.

Tested with kitchen test centos-7 and running successfully. :)

thoutenbos commented 7 years ago

Build is failing. Pinning rabbitmq to version 3.6.1 will probably fix it. The chef run in travis is a bit picky about the new version for some reason.

rmoriz commented 7 years ago

What exactly does this fix? Chef13 already worked in master…

@thoutenbos please release master ASAP so people wont fork and try to solve already fixed issues. thanks :)

rnt commented 7 years ago

@thoutenbos travis failed because the execution was 10 minutes without text output. When I did the test (kitchen-vagrant-virtualbox) it took about 15 minutes in total, but that did not happen.

@rmoriz this PR fixed the tests running with kitchen (and bump version).

Full kitchen test centos-7 output is here: https://pastebin.com/pQ3bTfzN

rmoriz commented 7 years ago

mariadb seems to be broken on CentOS. I'm getting the following error: https://travis-ci.org/rmoriz/chef-acme#L2098

Update:

Looks like RedHat.com and various other sites are down

GPG key retrieval failed: [Errno 14] curl#7 - "Failed connect to dl.fedoraproject.org:443; No route to host"

rmoriz commented 7 years ago

The RabbitMQ startup timeout also happens in the CI of the rabbitmq cookbook…

see https://github.com/rabbitmq/chef-cookbook/issues/435

thoutenbos commented 7 years ago

@rnt does it still make sense to rebase this after #71 ?

thoutenbos commented 7 years ago

Should be obsolete by now