search

schubergphilis / sensu-plugins-prometheus-checks

MIT License
14 stars 7 forks source link

Fix custom source name for IP address instances #11

Closed Crazybus closed 7 years ago

Crazybus commented 7 years ago

Custom metrics were defaulting the the app value from a metric when the instance name was an IP address. Now it is only using the app value when it exists and then defaulting to the instance name. This resulted in empty source names for custom metrics coming from instances being scrapped by IP address.

codecov-io commented 7 years ago

Codecov Report

Merging #11 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #11   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           8      8           
  Lines         358    358           
=====================================
  Hits          358    358
Impacted Files Coverage Δ
lib/sensu/plugins/prometheus/checks/runner.rb 100% <100%> (ø) :arrow_up:
lib/sensu/plugins/prometheus/metrics.rb 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 04b2be4...d78eb49. Read the comment docs.