search

schubergphilis / towerlib

A python library to interface with ansible tower's (awx) api.
MIT License
43 stars 39 forks source link

Addition of the workflow_nodes for WorkflowRunJob #122

Closed konono closed 1 year ago

konono commented 1 year ago

In the job.py file, I added a new property called workflow_nodes to the WorkflowJobRun class. This property is designed to retrieve information about the WorkflowNodes associated with a particular job run.

These changes appear to enhance the library's capabilities by allowing users to access WorkflowNodes information related to job runs and providing a dedicated class for modeling WorkflowNodes in Ansible Tower.

costastf commented 1 year ago

Hi @konono , thank you very much for this contribution! Would you mind moving the WorkflowNodes code under the job.py module and also add it in the relevant init.py since there is also a WorkflowJobRun class there and it feels like it fits. What do you think?

costastf commented 1 year ago

oh and please also add yourself on the Credits of the module and the CONTRIBUTING.rst in the root as a contributor.

konono commented 1 year ago

Hi @costastf , thank you your reply ! I have made corrections based on your suggestion, please review.

costastf commented 1 year ago

💪

costastf commented 1 year ago

v3.14 implements your changes, thanks again!