feat: ask_scm_branch_on_launch for job_template

schubergphilis / towerlib

A python library to interface with ansible tower's (awx) api.

MIT License

43 stars 39 forks source link

feat: ask_scm_branch_on_launch for job_template #128

Closed howardjones closed 8 months ago

howardjones commented 8 months ago

I wanted my job launcher to be able to validate AWX job template settings and this one was missing.

howardjones commented 8 months ago

Bit confused how my PR could be blocked by other people's changes that must have already been merged the same way :-)

howardjones commented 8 months ago

Lots of tests failing in things that weren't changed?

costastf commented 8 months ago

Hey, thanks for the contribution! I will make a new minor release. Sadly the tests have drifted quite some time ago,based on betamax recordings and were not very well thought of for all provided data and nobody realized for quite some time, which means that they are now requiring redoing from scratch for the current version of the service. Sadly no time for that but would love the help if anyone is up for it :)

costastf commented 8 months ago

v3.15.0 is uploaded with your changes.