search

schubergphilis / vagrant-chef-zero

Vagrant Plugin for Chef Zero
Apache License 2.0
91 stars 41 forks source link

Search gem bin paths to find one that contains a working chef-zero #19

Closed jgoldschrafe closed 9 years ago

jgoldschrafe commented 11 years ago

This modifies the approach for locating a working chef-zero binary so it works correctly with Bindler.

andrewgross commented 11 years ago

I am merging in changes that will use Chef-Zeros .start_background command instead of finding the binary ourself. That should obviate the need for this PR for now (ruby will do the work for us instead). However, I am going to leave this open since in the future we may change this behavior, and we will want to ensure we cover this case.

Thanks for submitting the PR!

andrewgross commented 11 years ago

I may take another look at this soon as we have switched back from using .start_background.

miguelaferreira commented 9 years ago

hi @jgoldschrafe would you be so kind as to check if there is still a problem working with Bindler, and if so, rebase you PR?

jgoldschrafe commented 9 years ago

Yikes, I haven't even directly invoked Vagrant in like a year now. Everything's through Test Kitchen, and I'm really far away from when this was all relevant to my workflow.

miguelaferreira commented 9 years ago

Thanks for the reply. I will close the issue for now, and if it reappears, then we will work on it.