search

schuderer / svgbuilder

Create interactive SVG models for lasercutting.
MIT License
1 stars 1 forks source link

Height of the slots on the ribs doesn't change with modified material thickness #13

Closed and-hus closed 1 year ago

and-hus commented 1 year ago

When changing the material thickness, the slots on the sides get narrower, but the slots on the ribs are not adapted to the new thickness: Katapult_Thickness_Issue

and-hus commented 1 year ago

Seems to be a refresh-issues. Reloading the page using f5 updates the height

schuderer commented 1 year ago

Thanks @and-hus ! I seem to have introduced this when I introduced properties for holeWidth and holeHeight to reduce the amount of magic numbers in the design. Unfortunately, these properties currently are only set once in Bar's construtor and then never update. PR welcome! :) I can also fix this as part of the PR I'm preparing for issue #4

schuderer commented 1 year ago

Closed with PR #14