schultek / jaspr

Modern web framework for building websites in Dart. Supports SPAs, SSR and SSG.
https://jasprpad.schultek.de
MIT License
1.07k stars 65 forks source link

Fix issue where title was always returning null #110

Closed slightfoot closed 11 months ago

slightfoot commented 12 months ago

Description

jaspr_router was not returning the page title. Looks like a refactor didnt catch the type change of r to RouteMatch instead of Route. Have added typed paramaters to deter this from happening again, and resolved bug by referring to the inner route.

Type of Change

Ready Checklist

If you need help, consider asking for advice on the #contribute channel on Discord.

docs-page[bot] commented 12 months ago

To view this pull requests documentation preview, visit the following URL:

docs.page/schultek/jaspr~110

Documentation is deployed and generated using docs.page.

github-actions[bot] commented 12 months ago

Package Version Report

The following packages have been updated: jaspr_router : 0.2.3 -> 0.2.4

codecov[bot] commented 12 months ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04% :tada:

Comparison is base (b19bd9b) 66.53% compared to head (a0b5204) 66.57%. Report is 18 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #110 +/- ## ========================================== + Coverage 66.53% 66.57% +0.04% ========================================== Files 96 96 Lines 3798 3803 +5 ========================================== + Hits 2527 2532 +5 Misses 1271 1271 ``` | [Files Changed](https://app.codecov.io/gh/schultek/jaspr/pull/110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kilian+Schulte) | Coverage ฮ” | | |---|---|---| | [packages/jaspr/lib/src/browser/dom\_renderer.dart](https://app.codecov.io/gh/schultek/jaspr/pull/110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kilian+Schulte#diff-cGFja2FnZXMvamFzcHIvbGliL3NyYy9icm93c2VyL2RvbV9yZW5kZXJlci5kYXJ0) | `68.80% <100.00%> (+0.25%)` | :arrow_up: | | [packages/jaspr\_router/lib/src/matching.dart](https://app.codecov.io/gh/schultek/jaspr/pull/110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kilian+Schulte#diff-cGFja2FnZXMvamFzcHJfcm91dGVyL2xpYi9zcmMvbWF0Y2hpbmcuZGFydA==) | `85.88% <100.00%> (+0.69%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.