schultek / jaspr

Modern web framework for building websites in Dart. Supports SPAs, SSR and SSG.
https://jasprpad.schultek.de
MIT License
1.07k stars 65 forks source link

Improvement: cli update #126

Closed schultek closed 10 months ago

schultek commented 10 months ago

Description

Improved the stability and logging of the cli and added the commands:

I also added a lightweight anonymous usage tracking to the cli. I'm using mixpanel.com for this as they have a free tier and well designed dashboards. I plan to make the usage dashboard public, but will wait until this is released for a few days to get enough events to have real anonymity.

Resolves #121

@dkbast DM me if you want a preview of the dashboard.

github-actions[bot] commented 10 months ago

Package Version Report

The following packages have been updated: jaspr : 0.9.0 -> 0.9.1 jaspr_builder : 0.9.0 -> 0.9.1 jaspr_cli : 0.9.0 -> 0.9.1 jaspr_test : 0.9.0 -> 0.9.1

codecov[bot] commented 10 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (87fc06f) 66.34% compared to head (c6b2d75) 66.34%. Report is 16 commits behind head on main.

:exclamation: Current head c6b2d75 differs from pull request most recent head 13ff7cf. Consider uploading reports for the commit 13ff7cf to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #126 +/- ## ======================================= Coverage 66.34% 66.34% ======================================= Files 96 96 Lines 3824 3824 ======================================= Hits 2537 2537 Misses 1287 1287 ``` | [Files](https://app.codecov.io/gh/schultek/jaspr/pull/126?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kilian+Schulte) | Coverage Δ | | |---|---|---| | [packages/jaspr/lib/src/server/server\_app.dart](https://app.codecov.io/gh/schultek/jaspr/pull/126?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kilian+Schulte#diff-cGFja2FnZXMvamFzcHIvbGliL3NyYy9zZXJ2ZXIvc2VydmVyX2FwcC5kYXJ0) | `62.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fusion44 commented 10 months ago

I'll update my local copy this weekend and give it a try. Looks like a great addition.

The only gripe I have as I scroll through the code is that there doesn't seem to be a way to opt out of the analytics. Especially as the project name is always logged.

schultek commented 10 months ago

Cool thanks for testing.

You're right I forgot to add a way to opt out. Will do so.

The project id is hashed before its sent. I thought it might be a good metric to trac distinct projects in addition to distinct users.

schultek commented 10 months ago

@fusion44 updated to allow disabling analytics