Closed fuzzybinary closed 9 months ago
The following packages have been updated: jaspr : 0.9.2 -> 0.9.3 jaspr_builder : 0.9.2 -> 0.9.3 jaspr_cli : 0.9.2 -> 0.9.3 jaspr_test : 0.9.2 -> 0.9.3
Attention: 2 lines
in your changes are missing coverage. Please review.
Comparison is base (
e953451
) 66.34% compared to head (aefa7d6
) 66.34%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@fuzzybinary Feel free to open another PR and add yourself to the AUTHORS file.
Description
When running jaspr through
dart .\lib\main.dart
or through a built Jaspr executable the _findRootProjectDir (in lib/src/server/server_handler.dart) would enter an infinite loop becausePlatform.script.path
returns the the path with a leading slash.This changes requests for
Platform.script.path
toPlatform.script.toFilePath()
which is more correct.Also fix
melos format
on Windows and the real server test on Windows.This also updates
modules/build
to a valid commit.Fixes #130
Type of Change
Ready Checklist
///
).