schultek / jaspr

Modern web framework for building websites in Dart. Supports SPAs, SSR and SSG.
https://jasprpad.schultek.de
MIT License
1.07k stars 65 forks source link

fix: Add .exe extension to Windows SSR executables #134

Closed fuzzybinary closed 9 months ago

fuzzybinary commented 9 months ago

Description

The executable built by jaspr build doesn't have an extension, but on Windows the extension is necessary for Windows to recognize it as an executable.

This adds the .exe extension if jaspr build is running on Windows with the target set to exe (as opposed to any snapshots). It may be worth revisiting this logic to add extensions for the two snapshot targets as well.

Type of Change

Ready Checklist

github-actions[bot] commented 9 months ago

Package Version Report

The following packages have been updated: jaspr : 0.9.2 -> 0.9.3 jaspr_builder : 0.9.2 -> 0.9.3 jaspr_cli : 0.9.2 -> 0.9.3 jaspr_test : 0.9.2 -> 0.9.3

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (aefa7d6) 66.34% compared to head (96de858) 66.34%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #134 +/- ## ======================================= Coverage 66.34% 66.34% ======================================= Files 96 96 Lines 3824 3824 ======================================= Hits 2537 2537 Misses 1287 1287 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.