search

schultek / jaspr

Modern web framework for building websites in Dart. Supports SPAs and SSR.
https://jasprpad.schultek.de
MIT License
1k stars 59 forks source link

rect component should not require "x" and "y" attributes #189

Closed walsha2 closed 3 months ago

walsha2 commented 4 months ago

Description

The following is an entirely valid rect component per HTML spec:

<rect width="100" height="100" />

https://developer.mozilla.org/en-US/docs/Web/SVG/Element/rect

However, the jaspr prebuilt rect component requires x and y to be defined as non-nullable strings. Not sure why these need to be required?

Proposal

These should be nullable, optional, string inputs - just like width and height

schultek commented 3 months ago

True, don't know how that slipped in

schultek commented 3 months ago

Fixed in master, will release with the other stuff