search

schultek / jaspr

Modern web framework for building websites in Dart. Supports SPAs, SSR and SSG.
https://jasprpad.schultek.de
MIT License
1.22k stars 74 forks source link

fix bug with base paths #199

Closed schultek closed 6 months ago

schultek commented 6 months ago

Description

Fixes #200

Type of Change

Ready Checklist

github-actions[bot] commented 6 months ago

Package Version Report

The following packages have been updated: jaspr : 0.11.0 -> 0.11.1 jaspr_builder : 0.11.0 -> 0.11.1 jaspr_cli : 0.11.0 -> 0.11.1 jaspr_test : 0.11.0 -> 0.11.1

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 52.38095% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 60.46%. Comparing base (0abb132) to head (7ed63e9). Report is 1 commits behind head on main.

Files Patch % Lines
...aspr/lib/src/server/adapters/document_adapter.dart 52.38% 10 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #199 +/- ## ========================================== - Coverage 60.47% 60.46% -0.02% ========================================== Files 117 117 Lines 5116 5124 +8 ========================================== + Hits 3094 3098 +4 - Misses 2022 2026 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

walsha2 commented 6 months ago

@schultek neither of the issues described in #200 seem to be resolved with these changes. I see the same exact problems using this PR branch. Anything else I need to do/configure? This is an existing app built using jaspr v0.10 - not that that should matter?

I am using the latest version of this branch as an override for jaspr_router.

pubspec.lock

  jaspr_router:
    dependency: "direct main"
    description:
      path: "packages/jaspr_router"
      ref: "fix/base-paths"
      resolved-ref: "7ed63e9d3826094abbb0d3da301f0cf862992928"
      url: "https://github.com/schultek/jaspr.git"
schultek commented 6 months ago

Changes are in jaspr, not jaspr_router

walsha2 commented 6 months ago

Changes are in jaspr, not jaspr_router

Oops - missed that in change log. Just confirmed that both items are indeed resolved. With or without a definition of <base href="/"> (by user) I get the same, expected, results.

LGTM. Thanks for the quick turnaround.