search

schultyy / os_type

Rust library to detect the operating system type
MIT License
30 stars 18 forks source link

0.7.0 Move distros to a HashSet,Impl Display and To_String for OSType,take apart redhat and centos,Complete top 10 distributions on distrowatch.com. #9

Closed biluohc closed 7 years ago

biluohc commented 7 years ago

Up the version to 0.7.0, move distros to a HashSet,Impl Display and To_String for OSType,take apart redhat and centos,Complete top 10 distributions on distrowatch.com.

biluohc commented 7 years ago

1:Sorry, I have modiffied the title and description.

2:Affect users who's distro be moved to hashset.So,i changed the version.

3:move disros to a hashset.There are too many distributions in the world. Are you sure you want to turn on the enumeration, and then write a bunch of 'ifelse'?

4:Most of the time we need a string description of the system。

5:Sorry，you maybe should to read and run the code，my english is bad.

schultyy commented 7 years ago

Hmm, I'm fine /w adding more distributions in the Enum. But I don't want to have a generic string solution in place too. Because from a library user's perspective this is not predicatable in the sense of which output to expect. Also the compiler can't be of assistance in case of typos.

Concerning a string representation for every distribution, after giving this some thought I would like to not have this in the library and rather let the library user deal with this if needed.

Because of the above reasons I am closing this PR now. I am happy to merge enum enhancements for other distributions though. 🙂