Closed unsoluble closed 3 years ago
Thanks for the reports. Fortunately these seem like they'll be relatively easy to handle just looking at the descriptions, though I probably won't get around to fixing these until the weekend.
The last warning about the speaker argument is actually a core dnd5e issue with rolling attacks and damage. I should have an update with fixes for the rest of these in a little while unless I find a last minute show stopper.
Ok, these should all be fixed now in MRE 2.0.0. If you could try it out and let me know if you find any problems that'd be great.
Awesome, will test this afternoon.
I can't make anything fail in 2.0.0, so I think you've got it. :)
Woo! I'll close this issue. If you find any other problems go ahead and open a new issue.
Skip
orShow
roll fine, but with deprecation warnings (reItem#_data
andDocument#_id
).Damage
button on any attack card nets aactor.getOwnedItem is not a function
.Automatically Roll Item Checks
causes all item rolls to fail, withUnable to recreate undefined instance from provided data
andCannot read property 'total' of null
.Attack
button do work without error, but with a deprecation warning ofYou are passing the speaker argument to the d20Roll function directly which should instead be passed as an internal key of messageData
.Sorry I'm not able to dig deeper to find possible causes/fixes; I'm not at all familiar with the dice/item APIs yet. And of course you'll see all this when you poke around anyway, but, here's a ticket to get things started. :)