search

schultzcole / FVTT-Skill-Customization-5e

Gives the ability to apply arbitrary flat bonuses to skill rolls as well as changing the base ability modifier a skill roll uses.
GNU General Public License v3.0
3 stars 9 forks source link

Return the result of rollSkill() to maintain compatibility #7

Closed CarlosFdez closed 3 years ago

CarlosFdez commented 3 years ago

The rollSkill() function in the 5e system actually returns a roll object(), which is used by modules as Midi (allegedly) and will be used by BetterRolls in a later version. However the rollSkill() overwrite you do does not return anything. If you add a return statement to https://github.com/schultzcole/FVTT-Skill-Customization-5e/blob/master/skl-customization.js#L60 it should (didn't test it) maintain compatibility by ensuring the type signature is compatible with vanilla 5e.

I started looking into it after @Sky-Captain-13 asked about compatibility with dice roll modifiers (like 1d4) in the discord.

schultzcole commented 3 years ago

Nice catch, I'll release an update with that change in a bit.

schultzcole commented 3 years ago

Added in 2.2.0