search

schungx / rhai

Rhai - An embedded scripting language for Rust [dev repo, may regularly force-push, pull from https://github.com/rhaiscript/rhai for a stable build]
https://github.com/rhaiscript/rhai
Apache License 2.0
9 stars 3 forks source link

Cleanup, breakage fixes, and CI fixes for codegen integration #24

Closed jhwgh1968 closed 4 years ago

jhwgh1968 commented 4 years ago

The version @schungx posted doesn't quite work based on tests. I fixed that.

In addition to actual breakage, there were a couple things I updated to look better, and a test I updated to act closer to the codegen module, even though other options were possible.

jhwgh1968 commented 4 years ago

Now I'm hitting CI issues that were nothing to do with code I changed in other Rhai tests. Could you please start merging your own PRs, rather than just committing to the plugins branch? Then I'd know they actually pass CI.

I can fix several of them, but I'd like to not have to keep doing it.

jhwgh1968 commented 4 years ago

You also didn't override the GHA workflow default to fail fast, which means the rest of the features are not tested when one fails, making finding issues with feature combinations slower than it should be. I'm fixing that too.