search

schungx / rhai

Rhai - An embedded scripting language for Rust [dev repo, may regularly force-push, pull from https://github.com/rhaiscript/rhai for a stable build]
https://github.com/rhaiscript/rhai
Apache License 2.0
9 stars 3 forks source link

Fix for export_prefix attribute on module macros #49

Closed jhwgh1968 closed 4 years ago

jhwgh1968 commented 4 years ago

This causes export_prefix to filter based on Rust item name, intentionally not taking any export names set by the name = ... attribute into account. @schungx pointed this out in #38.

One thing I did not do was presume that the presence of an export name automatically assumes that it should be exported. To handle that case, I am planning an always attribute that is the inverse of skip.

This is being merged to master, because I merged the other fix there by mistake. Once this is merged, I'd like master to be merged into plugins for the last little bit of work I do on this feature.

schungx commented 4 years ago

Will you add skip_prefix and skip_postfix? Or should I merge this one first?

jhwgh1968 commented 4 years ago

I put more commentary on that question in #38, but in short, I am trying to avoid writing those if I can.

schungx commented 4 years ago

OK