search

schveiguy / io

Core I/O functionality
Boost Software License 1.0
25 stars 9 forks source link

Fixes #32 - Cast the null to shared(Driver) to appease the cas template. #33

Closed schveiguy closed 4 years ago

schveiguy commented 4 years ago

ping @jondegenhardt I think this will have it build again. Can you test possibly before I merge?

jondegenhardt commented 4 years ago

I'm pretty busy today, I might be able to get to it tonight though.

schveiguy commented 4 years ago

OK, looks like all the things that were failing on CI are now green. So I'm just going to pull the lever and maybe your CI will go green as well.

jondegenhardt commented 4 years ago

Last time you updated the version number in the meson build file, but I don't see a change to that file. Did you miss this?

schveiguy commented 4 years ago

Ugh, yes. That was a problem I was concerned with (forgetting to update this build number), but it apparently is expected practice. Will update and move the tag.

jondegenhardt commented 4 years ago

For my own repos I have a "steps to do a release" notes file. Otherwise I'd forget. Little stuff like signing the tag commit.

schveiguy commented 4 years ago

@jondegenhardt updated meson build, and moved the tag.

jondegenhardt commented 4 years ago

Build succeeded on all compiler versions except for DMD v2.089.0. See https://travis-ci.com/jondegenhardt/dcat-perf/builds/149768223. The CI has 17 different DMD/LDC/Linux/OSX combos, so its got fair coverage.

jondegenhardt commented 4 years ago

Note that my CI doesn't explicitly test DMD 2.090.0. It does test latest, which is DMD 2.090.1. That release passed.

schveiguy commented 4 years ago

That was a regression, 2.089.1 works.

https://github.com/dlang/druntime/pull/2853

jondegenhardt commented 4 years ago

Excellent, thanks. I'll remove 2.089.0 from my CI tests.