schveiguy / raylib-d

Resurrected copy of onroundit's raylib-d
zlib License
55 stars 14 forks source link

Microscopic issue in a comment causes tons of warnings when using document builder #47

Closed cdcrchrisparker closed 7 months ago

cdcrchrisparker commented 7 months ago

This is in the comments only, hence does not affect code at all. There is a missing right paren in the comments for source/raylib/rlgl.d - this missing paren causes dozens of warnings whenever one uses the document generator. E.g.

dub build --build=docs

The solution? Line 78 of source/raylib/rlgl.d needs a trailing closing paren.

define RL_DEFAULT_SHADER_UNIFORM_NAME_NORMAL "matNormal" // normal matrix (transpose(inverse(matModelView)))

schveiguy commented 7 months ago

Please file in raylib upstream as well (if not already fixed) -- rlgl is mechanically translated using dstep.

cdcrchrisparker commented 7 months ago

Oh - okay. Didn't know that, I'll do so now. :)

schveiguy commented 7 months ago

Also, the doc builder is going to suck -- none of the docs will be used since they are only double-slash. I need to do some kind of mechanical translation of the raylib comments to ddoc comments.

See also #13

schveiguy commented 7 months ago

Please let me know if that works -- https://github.com/schveiguy/raylib-d/commit/9906279494f1f83b2c4c9550779d46962af7c342

I may not do a release unless you really need it, as this affects nothing normally used.

cdcrchrisparker commented 7 months ago

I'm actually only interested in my own documentation, and was mildly surprised that the doc builder builds library stuff as well.

Having said that, I might some spare cycles helping out with DDOC at some point in the near future.

schveiguy commented 7 months ago

OK, I'll do a release so it doesn't affect your project, sorry.

cdcrchrisparker commented 7 months ago

I edited my own version by hand. Not to worry about the release, it's not an issue at all. I just thought you'd like to know since it looks horrible when generating docs, and has such a simple resolution.

schveiguy commented 7 months ago

Well, I already did it ;) Not a huge deal.

schveiguy commented 7 months ago

Having said that, I might some spare cycles helping out with DDOC at some point in the near future.

That would be really great!