search

schwa23 / cleanupsfui

Sketch Plugin to clean up SF UI/Pro fonts character spacing & normalize text & display variants.
MIT License
56 stars 6 forks source link

1.5.2 breaks plugin #12

Closed allisonacs closed 7 years ago

allisonacs commented 7 years ago

Sorry to keep filing bugs.

After installing the latest update via Sketch's update system, the plugin disappears from the plugin menu, although the plugin file remains in the plugins folder.

After manually deleting the plugin and reinstalling it, the problem persists (not present in the plugin menu, but present in the plugin folder).

image

schwa23 commented 7 years ago

Are you running v47?

allisonacs commented 7 years ago

46.2 (have to hold off on the update for another day or so). FWIW, this was an issue in the previous release as well, but I was able to resolve it by manually deleting and reinstalling.

schwa23 commented 7 years ago

I can't reproduce on my end -- I uninstalled and reinstalled and it shows up. I'm not an expert on plugins tho, i'll dig around and see if I can figure it out. If you have anything in your Console that might be helpful. It's also possible that somehow it's conflicting with another plugin (seems unlikely)? just out of curiousity if you remove all the other plugins except CleanUp SFUI does it appear?

schwa23 commented 7 years ago

actually I think I have an idea what's going on. the zip file wasn't packaged properly

allisonacs commented 7 years ago

Yea I think you're right. When I downloaded the master and installed from there, it installed properly.

schwa23 commented 7 years ago

sorry!

allisonacs commented 7 years ago

No worries! Thank you for making this plugin and being so responsive to issues! 🙌

schwa23 commented 7 years ago

Updated the archive in the 1.5.2 release, plus version bumped to 1.5.3 to be safe https://github.com/schwa23/cleanupsfui/commit/eabb98021e27c1719089d82b306840e3e84a4efc