search

schwa23 / cleanupsfui

Sketch Plugin to clean up SF UI/Pro fonts character spacing & normalize text & display variants.
MIT License
56 stars 6 forks source link

Line Heights #9

Open kidcap opened 7 years ago

kidcap commented 7 years ago

Love this plugin, happy to see the SF Pro update. 👍🏼

Would still love to see line-heights adjusted to the recommended values too!

allisonacs commented 7 years ago

I would personally not want to see that. My team designs with SF Pro bc we use a system font stack on the web, but our type scale doesn't follow what Apple might recommend (as our type will display as Segoe or Roboto, etc. depending on the user's OS). Specifying our own line-heights helps us maintain consistency across platforms.

Please don't implement this as a default (totally cool with it being an option though!).

schwa23 commented 7 years ago

I'm inclined to agree with @allisonacs; changing the line heights could be unexpected if you are using a custom system. If I have time to add another command that applies line heights I might (or if someone wants to add it I accept pull requests!)