search

schwabe / ics-openvpn

OpenVPN for Android
3.31k stars 1.19k forks source link

Added Allowed Apps Checkbox for Mobile Data #1445

Closed beimoe closed 2 years ago

beimoe commented 2 years ago

A feature to have selective app access depending on your connection (mobile / wifi). Can e.g. save mobile traffic for hungry applications like phone updates and so on.

schwabe commented 2 years ago

So what is the purpose of this PR? It decides if an app will use non-VPN or VPN connection depending on whether the VPN was started on wifi or mobile?

beimoe commented 2 years ago

So what is the purpose of this PR? It decides if an app will use non-VPN or VPN connection depending on whether the VPN was started on wifi or mobile?

Yes, correct. Together with the new Android 11 Killswitch to forbid any data next to Vpn it has the purpose of similar "firewall" applications. There are other "pseudo" VPN firewall solutions for this, but 2 vpns at a time are not possible.

schwabe commented 2 years ago

This function needs to have a very good explaination in the UI to understand what it does to be integrated in the app. And I think the behaviour that an app is excluded from the if the VPN was connected on mobile but continues to be excluded when you roam to WiFi is weird and will be considered as a bug by most users.

beimoe commented 2 years ago

That should not be the expected behavior. Since the client reconnects on wifi/mobile switching with the then correct allowed app list, the behavior on mobile or wifi is always the same and predictable.

beimoe commented 2 years ago

Oh, I accidently closed the request. If this is also what you wish, I have done it for you ;-) If not, please reopen, thank you!

schwabe commented 2 years ago

I am just saying that this PR needs more polishing and fixing before I will accept, I am not refusing it. I am just not accepting it in the current form.