search

schwabe / ics-openvpn

OpenVPN for Android
3.36k stars 1.2k forks source link

Indonesian should be id not in #1481

Closed KwadroNaut closed 2 years ago

KwadroNaut commented 2 years ago

To make issues more manageable, I would appreciate it if you fill out the following details as applicable:

General information

  1. Tried with Android 9 and 10
  2. Version: latest master branch: main/src/ui/res/values-in/strings.xml

Description of the issue

There are Indonesian (Bahasa) translations, but they're not shown in the interface. They should be in values-id instead. You can replicate by switching your system preferred languages.

schwabe commented 2 years ago

Have enabled custom translations under general settings?

Android screwed up the language code for Indonesian, so I think the values-in is correct.

schwabe commented 2 years ago

See also here: https://stackoverflow.com/questions/13291578/how-to-localize-an-android-app-in-indonesian-language

KwadroNaut commented 2 years ago

I wasn't aware of the language switch in the settings, thanks. I wasn't aware that Java did this wrong a long time ago: api level 1: https://web.archive.org/web/20160215064626/http://developer.android.com/reference/java/util/Locale.html Sorry for the noise.