search

schwabe / ics-openvpn

OpenVPN for Android
3.25k stars 1.18k forks source link

Disconnect confirmation #1695

Closed chiragkrishna closed 3 weeks ago

chiragkrishna commented 4 months ago

General information

  1. Android Version: Andoird 14
  2. Android Vendor/Custom ROM: Samsung OneUI 6.0
  3. Device: Galaxy S22+
  4. Version of the app: play store: 0.7.51

Description of the issue

Disconnect button on notifications tray is intended to disconnect but results in asking for confirmation, this behaviour is not seen in the quick settings tray.

Disconnecting from notification panel

disconnect_notify

Results in confirmation pop up

dissconnect_confirm

Disconnecting from notification quick panel works perfectly without any confirmation

disconnect_quick

Mick-Mi commented 2 months ago

yeah I think we don't need the confirmation prompt.

schwabe commented 3 weeks ago

I will keep the confirmation. The extra click should not be that problematic and it has like this forever.

chiragkrishna commented 3 weeks ago

yes, its not problematic, but is a headache for automation. wouldn't hurt to add a dont ask again option though.