search

schwarzdavid / bootstrap-email

MIT License
27 stars 11 forks source link

Update dependencies for Cheerio compatibility #10

Closed vinialves008 closed 3 years ago

arlopezg commented 3 years ago

Hey there,

This solves an issue I've just run into while compiling a single template file.

cheerio is not a function

Is there anything stopping this from being merged/reviewed? @schwarzdavid

vinialves008 commented 3 years ago

I do not think so.

arlopezg commented 3 years ago

I made a ticket for better visibility and context https://github.com/schwarzdavid/bootstrap-email/issues/13

vinialves008 commented 3 years ago

ok

schwarzdavid commented 3 years ago

I will clean up the file changes a bit so that there are no unnecessary line (https://github.com/schwarzdavid/bootstrap-email/pull/10/files#diff-41c34a700e95afbb4dfef662948c9a1c240c03f3eeb2f95bd975412c0807d29dR99 for example) changes in the log and merge tonight

arlopezg commented 3 years ago

Awesome! This may help lots of people.