search

schwehr / generic-sensor-format

Sonar Generic Sensor Format (gsf) codec
Other
13 stars 8 forks source link

Should "unknown" really be truncated? #38

Open schwehr opened 9 years ago

schwehr commented 9 years ago 
egrep -n 'UNKN[^O]' *.[ch]
gsf.c:88:#define GSF_UNKNOWN_PARAM_TEXT "UNKNWN"   /* Flag value for unknown parameter value. */
gsf.c:7010:            sprintf(temp, "GEOID=UNKNWN");
gsf.h:1538:#define GSF_POS_TYPE_UNKN "UNKN"               /* Unknown positioning system type. */

Looks like "UNKNWN" is in use, but UNKN is not. Can it be removed or should it be changed to UNKNWN?

grep  -n GSF_UNKNOWN_PARAM_TEXT *.[ch] | wc -l 
     189
grep  -n GSF_POS_TYPE_UNKN *.[ch] | wc -l 
      1