schwehr / libais

C++ decoder for Automatic Identification System for tracking ships and decoding maritime information
Other
215 stars 94 forks source link

Possibly missing calls to ais8_1_26_append_pydict_sensor_hdr in ais_py.cpp #214

Open andyvan-trabus opened 2 years ago

andyvan-trabus commented 2 years ago

I noticed while implementing parsing for ais8_367_33, which is remarkably similar, that the switch statement in ais8_1_26_append_pydict only calls ais8_1_26_append_pydict_sensor_hdr for a couple of the cases (SENSOR_LOCATION, SENSOR_STATION), but not for any of the others. Since I don't have the message standard, I don't know whether this is an oversight or not.

From the similarity with ais8_367_33 I suspect that all of these cases should call that routine.